-
Notifications
You must be signed in to change notification settings - Fork 3
ci(NODE-6185): Add test and lint tasks to CI #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 14 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
6254a4c
Create codeql.yml
baileympearson 94146c2
add test and lint
baileympearson 6a851a3
remove unnecessary fiels
baileympearson 0352124
add names
baileympearson 039f9ed
add names
baileympearson 74f96c8
parameterize build platform for action
baileympearson f4106c2
Merge branch 'main' into NODE-6185
baileympearson 7c24f0a
add testing to build pipelien
baileympearson 3ce8108
test in build pipeline too
baileympearson a1761bd
misc cleanup and test fix
baileympearson d2a2b76
fix release test
baileympearson aea19c6
revert changes to build?
baileympearson b55e2fb
add convenience method for install and fix lint
baileympearson 5cf2bac
Merge branch 'main' into NODE-6185
baileympearson a1e3822
Update .github/docker/Dockerfile.glibc
baileympearson d57e9b0
Update .github/workflows/lint.yml
baileympearson 5dbd605
Update .github/workflows/lint.yml
baileympearson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
name: Lint | ||
|
||
on: | ||
push: | ||
branches: [ "main" ] | ||
pull_request: | ||
branches: [ "main" ] | ||
|
||
jobs: | ||
build: | ||
runs-on: ubuntu-latest | ||
|
||
name: ${{ matrix.lint-target }} | ||
strategy: | ||
matrix: | ||
lint-target: ["c++", "typescript"] | ||
nbbeeken marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
steps: | ||
- uses: actions/checkout@v4 | ||
- name: Use Node.js ${{ matrix.node-version }} | ||
uses: actions/setup-node@v3 | ||
with: | ||
node-version: ${{ matrix.node-version }} | ||
cache: 'npm' | ||
- name: "Build libmongocrypt" | ||
shell: bash | ||
run: | | ||
node .github/scripts/libmongocrypt.mjs | ||
baileympearson marked this conversation as resolved.
Show resolved
Hide resolved
|
||
npm install | ||
npm run prebuild | ||
baileympearson marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
- if: matrix.lint-target == 'c++' | ||
shell: bash | ||
run: | | ||
npm run check:clang-format | ||
|
||
- if: matrix.lint-target == 'typescript' | ||
shell: bash | ||
run: | | ||
npm run check:eslint |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.