Skip to content

Rework skill validator script#11

Merged
nirinchev merged 4 commits intomainfrom
ni/skill-validator
Mar 10, 2026
Merged

Rework skill validator script#11
nirinchev merged 4 commits intomainfrom
ni/skill-validator

Conversation

@nirinchev
Copy link
Copy Markdown
Collaborator

This PR proposes the following changes:

  • Moves validate-skills.sh script to tools so that it can more easily be accessed outside of github actions.
  • Tweaks validate-skills.sh behavior:
    • Removes changed file logic - the script already runs very quickly and passing structural validation is a prerequisite for merging PRs to main, making the logic to only run on changed files unnecessarily complex for the value we're getting.
    • Adds validation that skill-validator is installed.
    • Decouple reporting from GHA, so that it can be used locally.
  • Stub a basic CONTRIBUTING.md with instructions how to run the validate-skills script as well as the review-skill skill.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reworks the skill validator script by moving it from .github/scripts/ to tools/ (making it accessible outside GitHub Actions), simplifying its behavior (removing git-diff-based changed-file logic in favor of always validating all skills), adding local usability improvements (tool availability check, environment-aware output), and adding a CONTRIBUTING.md with contributor documentation.

Changes:

  • Replaces .github/scripts/validate-skills.sh (changed-files logic, CI-only) with tools/validate-skills.sh (validates all skills, works both locally and in CI)
  • Updates .github/workflows/validate-skills.yml to call the new script location, removes paths: trigger filter and fetch-depth: 0 requirement
  • Adds CONTRIBUTING.md with instructions for adding and testing skills

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
tools/validate-skills.sh New unified validator script with local/CI environment detection, tool availability check, and clean output
.github/scripts/validate-skills.sh Deleted — replaced by tools/validate-skills.sh
.github/workflows/validate-skills.yml Updated to point to new script; removed changed-files path filter and full fetch-depth requirement
CONTRIBUTING.md New contributor guide with skill creation and testing instructions


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tools/validate-skills.sh Outdated
Comment thread CONTRIBUTING.md Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 9, 2026 22:13
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread CONTRIBUTING.md
@nirinchev
Copy link
Copy Markdown
Collaborator Author

I'm going to go ahead and merge this as there's a few other PRs that are blocked on it, but feel free to do a comprehensive review and I'll address the comments in a follow-up.

@nirinchev nirinchev merged commit 7a4ace9 into main Mar 10, 2026
2 checks passed
@nirinchev nirinchev deleted the ni/skill-validator branch March 10, 2026 11:25
dacharyc added a commit that referenced this pull request Mar 10, 2026
dacharyc added a commit that referenced this pull request Mar 10, 2026
nirinchev added a commit that referenced this pull request Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants