Conversation
There was a problem hiding this comment.
Pull request overview
This PR reworks the skill validator script by moving it from .github/scripts/ to tools/ (making it accessible outside GitHub Actions), simplifying its behavior (removing git-diff-based changed-file logic in favor of always validating all skills), adding local usability improvements (tool availability check, environment-aware output), and adding a CONTRIBUTING.md with contributor documentation.
Changes:
- Replaces
.github/scripts/validate-skills.sh(changed-files logic, CI-only) withtools/validate-skills.sh(validates all skills, works both locally and in CI) - Updates
.github/workflows/validate-skills.ymlto call the new script location, removespaths:trigger filter andfetch-depth: 0requirement - Adds
CONTRIBUTING.mdwith instructions for adding and testing skills
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
tools/validate-skills.sh |
New unified validator script with local/CI environment detection, tool availability check, and clean output |
.github/scripts/validate-skills.sh |
Deleted — replaced by tools/validate-skills.sh |
.github/workflows/validate-skills.yml |
Updated to point to new script; removed changed-files path filter and full fetch-depth requirement |
CONTRIBUTING.md |
New contributor guide with skill creation and testing instructions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
I'm going to go ahead and merge this as there's a few other PRs that are blocked on it, but feel free to do a comprehensive review and I'll address the comments in a follow-up. |
This PR proposes the following changes:
validate-skills.shscript totoolsso that it can more easily be accessed outside of github actions.validate-skills.shbehavior:skill-validatoris installed.review-skillskill.