Skip to content

RUBY-3667 - If BSON::ObjectId(...) is given an existing object ID, it should return it without creating a new one #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

RUBY-3667 - If BSON::ObjectId(...) is given an existing object ID, it should return it without creating a new one #350

wants to merge 2 commits into from

Conversation

johnnyshields
Copy link
Contributor

Fixes RUBY-3667

I implemented this in BSON::ObjectId#from_string, which is the underlying method of BSON::ObjectId()

@johnnyshields
RUBY-3667 - If BSON::ObjectId(...) is given an existing object ID, it…
7966e65 
… should return it without creating a new one.

I implemented this in BSON::ObjectId#from_string.
@johnnyshields johnnyshields requested a review from a team as a code owner May 5, 2025 18:04
@johnnyshields johnnyshields changed the title RUBY-3667 - If BSON::ObjectId(...) is given an existing object ID, it should return it without creating a new one. RUBY-3667 - If BSON::ObjectId(...) is given an existing object ID, it should return it without creating a new one May 5, 2025
@johnnyshields
Copy link
Contributor Author

Please enable the button to "Update Branch" with the latest code. It makes my life easier!

@alexbevi
Copy link
Contributor

alexbevi commented May 6, 2025

Please enable the button to "Update Branch" with the latest code. It makes my life easier!

Always suggest updating pull request branches enabled

@codeowners-service-app codeowners-service-app bot requested a review from alexbevi May 30, 2025 02:44
@codeowners-service-app codeowners-service-app
Copy link

Assigned alexbevi for team dbx-ruby because comandeo-mongo is out of office.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@comandeo-mongo comandeo-mongo Awaiting requested review from comandeo-mongo comandeo-mongo is a code owner automatically assigned from mongodb/dbx-ruby

@alexbevi alexbevi Awaiting requested review from alexbevi

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnnyshields @alexbevi