DOCSP-40133: custom auth provider #163
Conversation
| The following code specifies the configuration properties to use the | ||
| ``MONGODB-AWS`` authentication method and add a custom authentication | ||
| provider: |
There was a problem hiding this comment.
Nit: I don't think "code" is the right way to describe config variables.
| The following code specifies the configuration properties to use the | |
| ``MONGODB-AWS`` authentication method and add a custom authentication | |
| provider: | |
| The following configuration properties specify the use of the | |
| ``MONGODB-AWS`` authentication method and add a custom authentication | |
| provider: |
| Depending on the design of your implementation class, you might also | ||
| set the ``mongodbaws.auth.mechanism.roleArn`` property, which | ||
| provides the Amazon Resource Name (ARN). |
There was a problem hiding this comment.
Can this be a part of the bulleted list above and marked as (optional)?
| The ``AwsAssumeRoleCredentialProvider`` class defines ``init()`` and | ||
| ``validate()`` methods that are called when the connector initializes. |
There was a problem hiding this comment.
It could be helpful for developers reading this to give a quick rundown of these methods and what devs would have to do to implement them – maybe a few comments above those methods in the code sample to give a brief overview of what they do?
|
Its a custom authentication provider, not specific to AWS IAM. We are providing a sample to do AWS IAM Auth though, the way the docs are written sounds like it is just AWS IAM support. |
mcmorisi
left a comment
mcmorisi
left a comment
There was a problem hiding this comment.
LGTM. Really great job on this!
… DOCSP-40133-custom-authprovider
| Atlas Group IAM Role. | ||
| access to MongoDB Atlas. In the AWS IAM console, the IAM account that is | ||
| running {+kafka-connect+} has ``AssumeRole`` permissions to this Atlas | ||
| Group IAM Role. |
| "mongodbaws.auth.mechanism.roleArn":"arn:aws:iam::99999999:role/KafkaAtlasRole" | ||
| "mongo.custom.auth.mechanism.enable": "true", | ||
| "mongo.custom.auth.mechanism.providerClass": "com.mongodb.SampleAssumeRoleCredential", | ||
| "mongodbaws.auth.mechanism.roleArn": "arn:aws:iam::99999999:role/KafkaAtlasRole" |
There was a problem hiding this comment.
replace arn:aws:iam with
There was a problem hiding this comment.
aws iam ARN something like that
|
LGTM |
* DOCSP-40133: custom auth provider * wip * vale * fixes * updates * add to wn * wip RW tech comments * RW comments * fix * fix * RW comments (cherry picked from commit e21986b)
3 participants
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-40133
Staging - https://preview-mongodbrustagir.gatsbyjs.io/kafka-connector/DOCSP-40133-custom-authprovider/security-and-authentication/custom-auth/
Self-Review Checklist