DOCSP-48557 Update Spark streaming write configuration to include all batch options#261
Conversation
✅ Deploy Preview for docs-spark-connector ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🔄 Deploy Preview for docs-spark-connector processing
|
shuangela
left a comment
shuangela
left a comment
There was a problem hiding this comment.
great job on this! added some comments related to wording as well as a question about a default setting in one of the parameters.
| w Option </reference/write-concern/#w-option>` in the {+mdb-server+} | ||
| manual. | ||
| | | ||
| | **Default:** ``1`` |
There was a problem hiding this comment.
Q: How did you get that this default is 1? the server manual states only that "If the write concern is missing the w field, MongoDB sets the w option to the default write concern," and then later on in the table it says "{ w: "majority" } is the default write concern for most MongoDB deployments". The implicit default write concern for most mongo deployments seems to be majority: https://www.mongodb.com/docs/manual/reference/write-concern/#std-label-wc-default-behavior
This question applies to the other writeConcern.w option as well
There was a problem hiding this comment.
I just moved what was on the batch page to the stream page, so I didn't write any of the info. I assumed most of it was correct but I'll double check everything now.
There was a problem hiding this comment.
I see that it can be 1 or majority, so I'm going to include both, with majority taking precedence as it is most cases like you said
There was a problem hiding this comment.
I think it's a bit odd if this option has two potential defaults, so it would be good to double check with the technical reviewer in this case
There was a problem hiding this comment.
Defaults to Acknowledged which is the default set by the server.
shuangela
left a comment
shuangela
left a comment
There was a problem hiding this comment.
lgtm with a note to ask tech reviewer for confirmation on something!
… batch options (mongodb#261) * DOCSP-48557 spark options update * DOCSP-48557 links and reorder * DOCSP-48667 link fix + mdb-server consistency * DOCSP-48557 wording * DOCSP-48557 remove ital * DOCSP-49557 update default w concern (cherry picked from commit 792cdc0)
… batch options (mongodb#261) * DOCSP-48557 spark options update * DOCSP-48557 links and reorder * DOCSP-48667 link fix + mdb-server consistency * DOCSP-48557 wording * DOCSP-48557 remove ital * DOCSP-49557 update default w concern (cherry picked from commit 792cdc0)
… batch options (mongodb#261) * DOCSP-48557 spark options update * DOCSP-48557 links and reorder * DOCSP-48667 link fix + mdb-server consistency * DOCSP-48557 wording * DOCSP-48557 remove ital * DOCSP-49557 update default w concern (cherry picked from commit 792cdc0)
… batch options (mongodb#261) * DOCSP-48557 spark options update * DOCSP-48557 links and reorder * DOCSP-48667 link fix + mdb-server consistency * DOCSP-48557 wording * DOCSP-48557 remove ital * DOCSP-49557 update default w concern (cherry picked from commit 792cdc0)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
4 participants
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-48557
Staging Links
Self-Review Checklist