fix: skip insights for queries with unsupported commands / operations INTELLIJ-316 #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
|
Earlier we were incorrectly identifying .iterator call always as a FIND_MANY command. In reality .iterator could be chained on any expression returning a MongoIterable. This change, removes explicit identification of .iterator as FIND_MANY command. IntelliJ eventually asks for a command for the right expression which is generally the bottom most expression in the call chain. The tests has been modified to replicate what IntelliJ does.
himanshusinghs
force-pushed
the
fix/INTELLIJ-316
branch
from
a662b44 to
b0bd329
Compare
kmruiz
approved these changes
May 23, 2025
himanshusinghs
changed the title
A command is an identified mongodb command such as $match. There are a few aggregate commands that our parsers do not support, in our case anything other than match, group, unwind, sort, project, addFields, at the time of this commit. Earlier the parser was skipping the command that it does not support but now we identify them and mark them as UNKNOWN so that later when we are making decision wether to run inspection on the query or not, we can decide that on the basis of whether the query has UNKNOWN command or not. The unknown operation detection logic has also been changed in this commit. Earlier it was only looking in Filters component and instead it should be looking at any component that has children for the Named operations.
himanshusinghs
force-pushed
the
fix/INTELLIJ-316
branch
from
dd9f447 to
56579a7
Compare
himanshusinghs
added
the
skip-spec-check
…ngCriteriaDialectParser as UNKNOWN operations
There was a problem hiding this comment.
Pull Request Overview
This PR improves the parser’s handling of unsupported commands and operations by consistently marking them as UNKNOWN, which ensures that insights are skipped for such unsupported queries. It also reverts a previous change regarding chaining queries and adds a data source connectivity check to avoid running inspections when disconnected.
- Skips insight generation for unsupported query commands/operations.
- Returns UNKNOWN nodes instead of null for unrecognized methods in aggregation stage parsing.
- Adds a connectivity check in inspections to prevent running when the data source is not connected.
Reviewed Changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/mongodb-dialects/spring-criteria/* | Updated test and parser logic for aggregation stages returning UNKNOWN for unsupported operations. |
| packages/mongodb-dialects/java-driver/* | Modified JavaDriverDialectParser to consistently return UNKNOWN nodes and updated tests for unsupported operations. |
| packages/jetbrains-plugin/* | Added a connectivity check in inspections and updated related tests and integrations. |
| packages/jetbrains-plugin/src/test/kotlin/com/mongodb/jbplugin/fixtures/* | Minor adjustments to account for new import patterns in integration tests. |
Comments suppressed due to low confidence (1)
packages/mongodb-dialects/java-driver/src/main/kotlin/com/mongodb/jbplugin/dialects/javadriver/glossary/JavaDriverDialectParser.kt:933
- Ensure that the allCallExpressions list contains at least two elements before accessing lastIndex - 1 to avoid potential IndexOutOfBounds errors in chained method calls.
val lastCallExpression = allCallExpressions.getOrNull(allCallExpressions.lastIndex - 1)
...s-plugin/src/main/kotlin/com/mongodb/jbplugin/inspections/AbstractMongoDbInspectionBridge.kt
Show resolved
Hide resolved
We regressed in one of the earlier commits about how we group our inspections in Settings -> Inspections panel in IntelliJ. This commits fixes that. The ideal grouping for our inspection is to be under one path which, earlier, we were calling "MongoDB". That is one thing we changed in this commit, populated groupPath metadata in plugin.xml for top level grouping. Then we have subgrouped inspections in their categories using groupKey metadata in plugin.xml.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Primarily this PR targets skipping the insights generation for queries that contains commands or operations that are not yet supported by our parsers. Earlier we were ignoring such commands / operations but now we are marking them as UNKNOWN and later using that information to decide whether to skip insight generation / inlay decoration for such queries or not.
The logic to detect whether the query has UNSUPPORTED operations or not, has also been modified. Earlier it was only looking in Filters component and instead it should have been looking at any component that has children for the Named operations, now it does as stated.
Additionally there are two other but important changes:
Checklist
Open Questions