test(NODE-6920): esm bundles do not have top-level await #790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
force-pushed
the
NODE-6920-import
branch
2 times, most recently
from
5e885a7 to
0865dbb
Compare
baileympearson
approved these changes
Apr 23, 2025
baileympearson
added
the
Primary Review
|
@baileympearson feel free to merge the other PR and then this one |
|
@nbbeeken I haven't reviewed (and wasn't planning on reviewing) the other PR. Do you need me to? |
|
I think it's worth the knowledge share, yes, please review it |
baileympearson
requested changes
Apr 24, 2025
nbbeeken
force-pushed
the
NODE-6920-import
branch
from
cc25714 to
57dda90
Compare
baileympearson
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
This PR is based on the changes in #749 it just adds the remaining testing and bundle renaming we need to finalize the change.
Is there new documentation needed for these changes?
What is the motivation for this change?
Check that we don't reintroduce a TLA in the browser or node bundle
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript