chore(NODE-6921): perf tests default to cwd and errexit #791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testing error: https://spruce.mongodb.com/version/6807edaab356e500077d17c2/ |
nbbeeken
force-pushed
the
NODE-6921-bson-perf
branch
from
ab6a1b2 to
bb448d3
Compare
nbbeeken
changed the title
baileympearson
added
the
Primary Review
@nbbeeken why did the spec benchmarks not fail? |
baileympearson
requested changes
Apr 23, 2025
I hadn't added the if stmt to the spec runner when I ran that patch, if you check the changes tab. I can run another patch to confirm |
baileympearson
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Is there new documentation needed for these changes?
What is the motivation for this change?
Use cwd for BSON by default
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript