EF-166: Logging for zero results from vector search and other tweaks #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rstam You were assigned as a reviewer automatically; feel free to ignore. |
ajcvickers
force-pushed
the
0911_HeedMe
branch
from
8fbdcc5 to
0cb8e6b
Compare
damieng
requested changes
Sep 22, 2025
| } | ||
|
|
||
| private const string VectorSearchNeedsIndexString = | ||
| "A vector query for '{entityType}.{propertyType}' could not be executed because the vector " + |
There was a problem hiding this comment.
Nice clear helpful error messages with next steps :)
| if (vectorIndexesInModel == null || vectorIndexesInModel.Count == 0) | ||
| { | ||
| ThrowForBadOptions( | ||
| $"A vector query for '{entityType!.DisplayName()}.{members[0].Name}' could not be executed because the vector " + |
There was a problem hiding this comment.
ThrowForBadOptions emits $"A vector query for '{entityType!.DisplayName()}.{members[0].Name}' could not be executed because {reason}"); so everything up to and including "because" here should be dropped.
|
|
||
| private sealed class VectorSearchReplacer : ExpressionVisitor | ||
| { | ||
| private readonly MethodCallExpression _removed; |
ajcvickers
force-pushed
the
0911_HeedMe
branch
from
0f2c4ff to
4fccf77
Compare
|
@damieng Ready for re-review. |
damieng
approved these changes
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.