Skip to content

Conversation

ajcvickers
Copy link
Collaborator

No description provided.

@ajcvickers ajcvickers requested review from Copilot and damieng October 10, 2025 14:52
@ajcvickers ajcvickers requested a review from a team as a code owner October 10, 2025 14:52
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a logging issue where MongoDB vector queries were exposing sensitive data in warning messages even when sensitive data logging was disabled (EF-270). The fix ensures that when sensitive data logging is turned off, the query details are properly redacted in zero results warnings.

  • Corrected vector query warning logging to respect sensitive data logging settings
  • Added comprehensive test coverage for both sensitive and non-sensitive logging scenarios
  • Enhanced test entities with vector search capabilities for proper testing

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/MongoDB.EntityFrameworkCore/Diagnostics/MongoLoggerExtensions.cs Fixed logging logic to properly redact sensitive query data in vector search warnings
tests/MongoDB.EntityFrameworkCore.FunctionalTests/LoggingTests.cs Added test cases to verify correct logging behavior with and without sensitive data
tests/MongoDB.EntityFrameworkCore.FunctionalTests/Entities/Guides/Planet.cs Added embedding field to Moon entity for vector search testing
tests/MongoDB.EntityFrameworkCore.FunctionalTests/Entities/Guides/GuidesDbContext.cs Configured vector index and test data for Moon entity

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ajcvickers ajcvickers requested review from Copilot and damieng October 13, 2025 17:17
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated no new comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@damieng damieng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like the simplified error message format.

@ajcvickers ajcvickers merged commit c0b8c64 into main Oct 13, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants