-
Notifications
You must be signed in to change notification settings - Fork 36
EF-271: Vector index filter fields do not use element mapping #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes an issue where vector index filter fields were not properly using element mapping from the Entity Framework model configuration. The fix ensures that when creating MongoDB vector indexes with filter options, the generated filter paths correctly reflect any custom element names defined through HasElementName()
configuration.
- Updates vector index creation logic to properly map filter field paths using configured element names
- Adds comprehensive test coverage for element name mapping in vector indexes
- Updates existing test assertions to reflect the corrected field name mappings
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
File | Description |
---|---|
src/MongoDB.EntityFrameworkCore/Metadata/InternalIndexExtensions.cs |
Core fix that implements proper element name mapping for vector index filter paths |
tests/MongoDB.EntityFrameworkCore.SpecificationTests/Query/VectorSearchMongoTestBase.cs |
Adds element name configuration to test entities for verification |
tests/MongoDB.EntityFrameworkCore.SpecificationTests/Query/VectorSearchMongoTest.cs |
Updates test assertions to use mapped element names in generated MongoDB queries |
tests/MongoDB.EntityFrameworkCore.SpecificationTests/Query/VectorSearchExactMongoTest.cs |
Updates test assertions for exact vector search scenarios |
tests/MongoDB.EntityFrameworkCore.FunctionalTests/Storage/IndexTests.cs |
Expands test coverage with element name mapping scenarios and updates test parameters |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/MongoDB.EntityFrameworkCore/Metadata/InternalIndexExtensions.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just the typo Copilot recommends.
…ns.cs Co-authored-by: Copilot <[email protected]>
No description provided.