Skip to content

Conversation

ajcvickers
Copy link
Collaborator

No description provided.

@ajcvickers ajcvickers requested review from Copilot and damieng October 10, 2025 16:55
@ajcvickers ajcvickers requested a review from a team as a code owner October 10, 2025 16:55
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes an issue where vector index filter fields were not properly using element mapping from the Entity Framework model configuration. The fix ensures that when creating MongoDB vector indexes with filter options, the generated filter paths correctly reflect any custom element names defined through HasElementName() configuration.

  • Updates vector index creation logic to properly map filter field paths using configured element names
  • Adds comprehensive test coverage for element name mapping in vector indexes
  • Updates existing test assertions to reflect the corrected field name mappings

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/MongoDB.EntityFrameworkCore/Metadata/InternalIndexExtensions.cs Core fix that implements proper element name mapping for vector index filter paths
tests/MongoDB.EntityFrameworkCore.SpecificationTests/Query/VectorSearchMongoTestBase.cs Adds element name configuration to test entities for verification
tests/MongoDB.EntityFrameworkCore.SpecificationTests/Query/VectorSearchMongoTest.cs Updates test assertions to use mapped element names in generated MongoDB queries
tests/MongoDB.EntityFrameworkCore.SpecificationTests/Query/VectorSearchExactMongoTest.cs Updates test assertions for exact vector search scenarios
tests/MongoDB.EntityFrameworkCore.FunctionalTests/Storage/IndexTests.cs Expands test coverage with element name mapping scenarios and updates test parameters

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ajcvickers ajcvickers requested a review from Copilot October 13, 2025 17:40
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@damieng damieng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the typo Copilot recommends.

@ajcvickers ajcvickers merged commit 9899a19 into main Oct 14, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants