SQL-2543: prepare to build both in one shot #323
Conversation
| export STATIC_CODE_ANALYSIS_NAME="mongo-odbc-driver.sast.sarif" | ||
| export FEATURE_FLAGS="" | ||
| export PRODUCT_NAME="mongoodbc" | ||
| export PATH_PREFIX="" |
There was a problem hiding this comment.
This could have been added for the S3 path. I don't see it being used, it can be removed if not.
There was a problem hiding this comment.
Yeah I removed it since the tasks have to be duplicated :(
evergreen/create-expansions.sh
Outdated
| PRODUCT_NAME: "$PRODUCT_NAME" | ||
| MSI_FILENAME: "$MSI_FILENAME" | ||
| UBUNTU_FILENAME: "$UBUNTU_FILENAME" | ||
| WINDOWS_INSTALLER_PATH: "${PRODUCT_NAME}/mongosql-odbc-driver/windows/$RELEASE_VERSION/release/$MSI_FILENAME" |
There was a problem hiding this comment.
This is changing the root directory we use for the eap builds. Is that intended?
evergreen/eap.yml
Outdated
| aws_key: ${release_aws_key} | ||
| aws_secret: ${release_aws_secret} | ||
| local_file: mongosql-odbc-driver/release/docs/MongoDB_ODBC_Guide.pdf | ||
| remote_file: eap/mongodb-odbc-driver/docs/MongoDB_ODBC_Guide.pdf |
There was a problem hiding this comment.
Related to the change of directory where the release artifacts are copied in now, the guide will still be under eap, while the other artifacts will be under mongodb-eap. It would be better to unify and use the same directory for all release artifacts.
There was a problem hiding this comment.
Yes I believe it would!
There was a problem hiding this comment.
@terakilobyte Sorry for the misunderstanding. I was thinking about unifying between mongoodbc-eap and eap as the root directory for eap builds.
It looks like right now, with the new changes, the msi and tar.gz will be in the same root directory than the regular non eap builds, but some other like atsql.dll will be in the eap directory.
Here is what I feel could work:
- Call generate expansion with eap true before calling upload release.
- Remove the hard coded
mongosql-odbc-driverfromWINDOWS_INSTALLER_PATHandUBUNTU2204_INSTALLER_PATH. - Add a variable in
create-expansions.sh, for exampleRELEASE_ROOT_DIRwhich should bemongosql-odbc-driverfor the regular non-eap releases andeap/mongosql-odbc-driverfor eap releases - Use the variable in
upload releaseto control where things go - Remove
upload eap releasefrom eap.yml and useupload releaseinstead after callinggenerate expansionwith the varsnapshot-eap: "true"
No description provided.