PHPC-2234: Implement object compare handler for WriteConcern#1968
Open
paulinevos wants to merge 1 commit intomongodb:v2.xfrom
Open
PHPC-2234: Implement object compare handler for WriteConcern#1968paulinevos wants to merge 1 commit intomongodb:v2.xfrom
paulinevos wants to merge 1 commit intomongodb:v2.xfrom
Conversation
paulinevos
requested review from
GromNaN and
Copilot
and removed request for
a team
There was a problem hiding this comment.
Pull request overview
This PR adds a custom object comparison handler for MongoDB\Driver\WriteConcern to support equality checks, along with a PHPT test validating the new behavior.
Changes:
- Implemented
phongo_writeconcern_compare_objectsand registered it as thecomparehandler forWriteConcern. - Added a new PHPT test for
WriteConcernequality and a fallback comparison case.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| tests/writeConcern/writeconcern-compare.phpt | Adds PHPT coverage for WriteConcern object comparison behavior. |
| src/MongoDB/WriteConcern.c | Introduces and registers a WriteConcern object compare handler. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
paulinevos
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a comparison handler for
WriteConcern. As sorting order forWriteConcernis arbitrary, this really only supports evaluating equality. Everything else always returns-1.This behavior will be documented in the PHP docs (will add link to PR when it's ready)
Docs PR lives here: php/doc-en#5454