Skip to content

Lock rector version to 2.5.9 - #1973

Merged
GromNaN merged 1 commit into
mongodb:v1.21from
GromNaN:rector-2.6.4
Aug 27, 2026
Merged

Lock rector version to 2.5.9#1973
GromNaN merged 1 commit into
mongodb:v1.21from
GromNaN:rector-2.6.4

Conversation

@GromNaN

@GromNaN GromNaN commented Aug 27, 2026

Copy link
Copy Markdown
Member

Locks the Rector version to prevent unexpected changes being proposed when new releases are available. Updates will only be made to the development branch.

Copilot AI lite review requested due to automatic review settings August 27, 2026 15:43
@GromNaN
GromNaN requested a review from a team as a code owner August 27, 2026 15:43
@GromNaN
GromNaN requested a review from paulinevos August 27, 2026 15:43
@GromNaN
GromNaN enabled auto-merge (squash) August 27, 2026 15:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Freezes the Rector dev dependency to a specific version to avoid unexpected refactor proposals from new Rector releases, and applies a set of Rector-driven refactors across runtime and test code.

Changes:

  • Pin rector/rector to 2.6.4 in composer.json.
  • Replace various isset/=== null initialization blocks with null coalescing assignment (??=) in src/ and tests/.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
composer.json Pins rector/rector to 2.6.4 to stabilize tooling output.
src/Client.php Uses ??= to inherit typeMap options more concisely.
src/Collection.php Simplifies defaulting of $toDatabaseName and writeConcern inheritance via ??=.
src/Database.php Simplifies defaulting of typeMap, encryptedFields, and $toDatabaseName via ??=.
src/Operation/BulkWrite.php Simplifies defaulting of optional operation arguments ($args[...]) via ??=.
tests/FunctionalTestCase.php Simplifies defaulting of optional $databaseName parameters via ??=.
tests/Operation/BulkWriteFunctionalTest.php Simplifies _id placeholder replacement logic via ??=.
tests/Operation/InsertManyFunctionalTest.php Simplifies _id placeholder replacement logic via ??=.
tests/Operation/InsertOneFunctionalTest.php Simplifies _id placeholder replacement logic via ??=.
tests/UnifiedSpecTests/EventCollector.php Simplifies lazy initialization of the class-to-event-name map via ??=.
tests/UnifiedSpecTests/UnifiedTestRunner.php Simplifies lazy initialization of cached requirement-check args via ??=.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Copilot AI review requested due to automatic review settings August 27, 2026 15:59
@GromNaN GromNaN changed the title Freeze rector version to 2.6.4 Lock rector version to 2.5.9 Aug 27, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

Comment thread composer.json
@GromNaN
GromNaN merged commit c1a419d into mongodb:v1.21 Aug 27, 2026
31 checks passed
@GromNaN
GromNaN deleted the rector-2.6.4 branch August 27, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants