Skip to content

RUBY-3461 Enable tests that require failCommand with appName on initial handshake before 4.9 #2901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2024
+13 −14
Merged

RUBY-3461 Enable tests that require failCommand with appName on initial handshake before 4.9 #2901

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions spec/spec_tests/data/client_side_operations_timeout/command-execution.yml
View file
Original file line number Diff line number Diff line change
@@ -3,9 +3,8 @@ description: "timeoutMS behaves correctly during command execution"
schemaVersion: "1.9"

runOnRequirements:
# The appName filter cannot be used to set a fail point on connection handshakes until server version 4.9 due to
# SERVER-49220/SERVER-49336.
- minServerVersion: "4.9"
# Require SERVER-49336 for failCommand + appName on the initial handshake.
- minServerVersion: "4.4.7"
# Skip load-balanced and serverless which do not support RTT measurements.
topologies: [ single, replicaset, sharded ]
serverless: forbid
6 changes: 3 additions & 3 deletions spec/spec_tests/data/sdam_unified/hello-command-error.yml
View file
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
---
description: hello-command-error

schemaVersion: "1.10"
schemaVersion: "1.4"

runOnRequirements:
# failCommand appName requirements
- minServerVersion: "4.9"
# Require SERVER-49336 for failCommand + appName on the initial handshake.
- minServerVersion: "4.4.7"
serverless: forbid
topologies: [ single, replicaset, sharded ]

7 changes: 3 additions & 4 deletions spec/spec_tests/data/sdam_unified/hello-network-error.yml
View file
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
---
description: hello-network-error

schemaVersion: "1.10"
schemaVersion: "1.4"

runOnRequirements:
# failCommand appName requirements
- minServerVersion: "4.9"
# Require SERVER-49336 for failCommand + appName on the initial handshake.
- minServerVersion: "4.4.7"
serverless: forbid
topologies: [ single, replicaset, sharded ]

@@ -140,7 +140,6 @@ tests:
# network error. Use "times: 4" to increase the probability that the
# Monitor check fails since the RTT hello may trigger this failpoint one
# or many times as well.
# The ruby driver only needs to fail twice because the RTT updates topology.
- name: failPoint
object: testRunner
arguments:
3 changes: 2 additions & 1 deletion spec/spec_tests/data/sdam_unified/interruptInUse-pool-clear.yml
View file
Original file line number Diff line number Diff line change
@@ -5,7 +5,7 @@ schemaVersion: "1.11"

runOnRequirements:
# failCommand appName requirements
- minServerVersion: "4.9"
- minServerVersion: "4.4"
serverless: forbid
topologies: [ replicaset, sharded ]

@@ -338,3 +338,4 @@ tests:
databaseName: *databaseName
documents:
- { _id: 1, a : bar }

6 changes: 3 additions & 3 deletions spec/spec_tests/data/sdam_unified/minPoolSize-error.yml
View file
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
---
description: minPoolSize-error

schemaVersion: "1.10"
schemaVersion: "1.4"

runOnRequirements:
# failCommand appName requirements
- minServerVersion: "4.9"
# Require SERVER-49336 for failCommand + appName on the initial handshake.
- minServerVersion: "4.4.7"
serverless: forbid
topologies:
- single