RUBY-3658 Ensure partial writes are retried #2927
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexbevi
previously approved these changes
Apr 25, 2025
focus on modern servers, recent rubies
jamis
changed the title
write() is blocking, but apparently may still not write the entire requested block (for various reasons). It is safest to NOT assume it wrote everything, and instead check the return value for the number of bytes actually written.
alexbevi
approved these changes
Apr 25, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Partial writes were not being retried when a timeout was present, which caused the count of bytes written to be incorrect, because fewer bytes were written to the server than intended. For large payloads (1MB+) this consistently resulted in requests timing out.