CLOUDP-121490 | feat: container resources customization #1713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow customization of resource requirements (CPU and memory) for all containers deployed by the MongoDB Kubernetes operator: - Add ResourcesSpec to MongoDBCommunitySpec - Implement safe resource retrieval using reflection - Support customization for mongod, agent, and init containers - Fall back to default values when not specified This enhancement gives users more control over the resource allocation for MongoDB deployments, which is particularly useful in production environments with specific resource constraints.
Jorgagu
requested review from
mircea-cosbuc,
lsierant,
nammn,
Julien-Ben,
MaciejKaras,
lucian-tosa,
fealebenpae and
m1kola
as code owners
Jorgagu
changed the title
Jorgagu
changed the title
|
👋 @dan-mckean, I’ve created this PR to close issue #962. Do you have an estimate of when you (or someone else) might review it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This pull request introduces support for specifying custom resource requirements for MongoDB pods, enabling fine-grained control over resource allocation for different containers. The changes include updates to the CRD, API types, and controller logic to incorporate this functionality.
API Enhancements
ResourcesSpectype inapi/v1/mongodbcommunity_types.goto define resource requirements for containers (mongod,agent,readinessProbe, andversionUpgradeHook). This type is integrated into theMongoDBCommunitySpecstruct. [1] [2]CRD Updates
config/crd/bases/mongodbcommunity.mongodb.com_mongodbcommunity.yamlto include theresourcesfield, allowing users to specify resource requirements for individual containers. This includes descriptions and validation rules forlimitsandrequests.Controller Modifications
BuildMongoDBReplicaSetStatefulSetModificationFunctionincontrollers/construct/mongodbstatefulset.goto handle the newResourcesSpec. This includes passing resource specifications to container creation functions formongod,agent,readinessProbe, andversionUpgradeHookcontainers. [1] [2] [3]mongodbContainer,mongodbAgentContainer,versionUpgradeHookInit,readinessProbeInit) to accept and apply resource requirements from theResourcesSpec. [1] [2] [3] [4]Test Updates
TestMongod_Containertest incontrollers/construct/build_statefulset_test.goto include aMongoDBCommunityinstance without custom resources, ensuring compatibility with the new functionality.These changes collectively enhance the flexibility and configurability of the MongoDB Kubernetes Operator, allowing users to better manage resource allocation for their deployments.
closes #962
All Submissions:
closes #XXXXin your comment to auto-close the issue that your PR fixes (if such).