CLOUDP-420747: Prepare CI to work on v# backport branches as well as master#1371
Draft
josvazg wants to merge 2 commits into
Draft
CLOUDP-420747: Prepare CI to work on v# backport branches as well as master#1371josvazg wants to merge 2 commits into
josvazg wants to merge 2 commits into
Conversation
Contributor
MCK 1.10.0 Release NotesNew Features
Bug Fixes
|
Comment on lines
44
to
47
| run: | | ||
| echo -e "_:warning: (this preview might not be accurate if the PR is not rebased on current master branch)_\n" > release_notes_tmp.md | ||
| echo -e "_:warning: (this preview might not be accurate if the PR is not rebased on current ${{ github.base_ref }} branch)_\n" > release_notes_tmp.md | ||
| cat release_notes_preview.md >> release_notes_tmp.md | ||
| mv -f release_notes_tmp.md release_notes_preview.md |
There was a problem hiding this comment.
Using variable interpolation ${{...}} with github context data in a run: step could allow an attacker to inject their own code into the runner. This would allow them to steal secrets and code. github context data can have arbitrary user input and should be treated as untrusted. Instead, use an intermediate environment variable with env: to store the data and use the environment variable in the run: script. Be sure to use double-quotes the environment variable, like this: "$ENVVAR".
🧼 Fixed in commit 22f52dd 🧼
josvazg
marked this pull request as draft
July 13, 2026 15:55
josvazg
force-pushed
the
CLOUDP-420747/backport-branches
branch
from
July 16, 2026 10:38
f7364f1 to
fb03c55
Compare
Signed-off-by: Jose Vazquez <jose.vazquez@mongodb.com>
josvazg
force-pushed
the
CLOUDP-420747/backport-branches
branch
from
July 16, 2026 10:52
fb03c55 to
22f52dd
Compare
Signed-off-by: Jose Vazquez <jose.vazquez@mongodb.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ensure the CI keeps working the same on master than on future back-porting branches v1, v2, v3.
Proof of Work
TBD
Checklist
skip-changeloglabel if not needed