CLOUDP-400891: Remove installClusterRole Helm Value

[roothorp]

Summary

Remove installClusterRole helm value, and also a test that checked if it worked (which is now useless because it doesn't exist anymore).

This functionality is now exclusively configured using operator.webhook.registerConfiguration

Proof of Work

Checklist

• Have you linked a jira ticket and/or is the ticket in the title?
• Have you checked whether your jira ticket required DOCSP changes?
• Have you added changelog file?
  • use skip-changelog label if not needed
  • refer to Changelog files and Release Notes section in CONTRIBUTING.md for more details

---

[josvazg]

q: isn't this missing the changelog entry? it is a breaking change on its own AFAIU

[m1kola]

Currently in master there are two things that gate webhook RBAC:

if and .Values.operator.webhook.registerConfiguration .Values.operator.webhook.installClusterRole

We've decided that operator.webhook.installClusterRole is redundant, but operator.webhook.registerConfiguration still stays in place and still gates RBAC.

IMO we should keep testing that there is a way to not deploy webhook RBAC and keep the operator functional. So the question is: do we have another test that does the same, but using operator.webhook.registerConfiguration? If yes - then we can remove it. If no - then we should update the test to use operator.webhook.registerConfiguration instead of operator.webhook.installClusterRole.

P.S: I think it is an overkill to run a whole E2E test just to test this. IMO it should be covered by Helm chart tests and unit tests (that the operator can handle absent RBAC well). That's an alternative you can explore, but not worth spinning wheels on it too much. Making existing approach work is good enough.