MONGOID-5890 Handle BSON::Decimal128 specially when checking for changes #6045
+32
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ges (mongodb#6042) * handle BSON::Decimal128 specially when checking for changes * Reference the correct option in the context name Co-authored-by: Copilot <[email protected]> * Apparently #to_d is a recent addition to ruby-bson --------- Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR backports a fix from version 6042 to handle BSON::Decimal128 specially when checking for attribute changes in Mongoid. The issue occurs when map_big_decimal_to_decimal128 is enabled, where identical numeric values are incorrectly marked as changed due to incompatible equality comparison between BSON::Decimal128 and BigDecimal types.
- Replaces direct attribute equality comparison with a new method that normalizes values before comparison
- Adds helper methods to convert BSON::Decimal128 to BigDecimal for proper equality checking
- Includes test coverage for the decimal128 scenario when the configuration option is enabled
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/mongoid/attributes.rb | Implements normalized value comparison logic and helper methods to handle BSON::Decimal128 equality |
| spec/mongoid/attributes_spec.rb | Adds test case to verify documents aren't marked as changed when writing identical decimal values |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
comandeo-mongo
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #6042 to 9.0-stable.