Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(NODE-6870): add tags to normalized_throughput #4478

Merged
merged 6 commits into from
Mar 20, 2025
Merged

Conversation

nbbeeken
Copy link
Contributor

@nbbeeken nbbeeken commented Mar 19, 2025

Description

What is changing?

NODE-6870

normalized_throughput didn't have the tags from the original metric

Is there new documentation needed for these changes?

What is the motivation for this change?

Tags are needed to add metrics to a context

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken marked this pull request as ready for review March 19, 2025 21:22
@nbbeeken nbbeeken requested a review from a team as a code owner March 19, 2025 21:22
@nbbeeken nbbeeken changed the title chore: add tags to normalized_throughput chore(NODE-6870): add tags to normalized_throughput Mar 20, 2025
@dariakp dariakp self-assigned this Mar 20, 2025
@dariakp dariakp added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Mar 20, 2025
@dariakp dariakp merged commit 20f7db7 into main Mar 20, 2025
27 of 31 checks passed
@dariakp dariakp deleted the fix-perf-tags branch March 20, 2025 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants