test(NODE-6492): add integration tests for transaction write concern behavior #4490
Conversation
baileympearson
added
the
Primary Review
|
|
||
| describe('Transactions Spec Prose', function () { | ||
| let client: MongoClient; | ||
| const started = []; |
There was a problem hiding this comment.
Do you think it is worth updating the spec with the additional requirements you found here? Looks like Python's implementation has found the same things (they're the only other driver that has implemented the test so far).
- requires transactions (4.0+, non-sharded. 4.2+, sharded)
- you must create the collection / ensure it exists beforehand
There was a problem hiding this comment.
|
|
||
| const insertStarted = started.find(ev => ev.commandName === 'insert'); | ||
| expect(insertStarted).to.not.have.nested.property('command.writeConcern'); | ||
|
|
There was a problem hiding this comment.
Are we missing the following check?
Ensure the document was inserted and no error was thrown from the transaction.
There was a problem hiding this comment.
No, its just by nature of the insert / commitTransaction not throwing. Checking the command started is sort of unreachable, if the WC is set the commitTxn throws, but its a reasonable double-check
There was a problem hiding this comment.
Python checks that the result of the insert is an inserted id. We could also query the collection after the transaction for our doc - either would satisfy the "confirm the document was inserted".
This is important because w: 0 doesn't throw but might not insert.
Description
What is changing?
Add prose test - NODE-6492
Is there new documentation needed for these changes?
No
What is the motivation for this change?
Spec compliance
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript