Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(NODE-5466): update MongoDB version requirement for changeStreamSplitLargeEvent prose tests #4491

Merged
merged 1 commit into from
Mar 26, 2025
Merged

test(NODE-5466): update MongoDB version requirement for changeStreamSplitLargeEvent prose tests #4491

merged 1 commit into from
Mar 26, 2025

Conversation

nbbeeken
Copy link
Contributor

Description

What is changing?

Update version requirement

Is there new documentation needed for these changes?

No

What is the motivation for this change?

Spec compliance

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@nbbeeken nbbeeken requested a review from a team as a code owner March 26, 2025 15:52
@baileympearson
Copy link
Contributor

Confirmed that the new test runs and is passing in CI: https://parsley.mongodb.com/evergreen/mongo_node_driver_next_rhel80_large_Node20_test_6.0_replica_set_patch_1f8e01f098ed4db6208fef482abadb8c5513c157_67e422c18a602b0006ae9aa3_25_03_26_15_52_34/0/task?bookmarks=0,9039&shareLine=972

baileympearson
baileympearson requested changes Mar 26, 2025
View reviewed changes
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test server range

@baileympearson baileympearson self-assigned this Mar 26, 2025
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Mar 26, 2025
@nbbeeken nbbeeken requested a review from baileympearson March 26, 2025 17:20
@baileympearson baileympearson merged commit 85440c4 into main Mar 26, 2025
27 of 30 checks passed
@baileympearson baileympearson deleted the NODE-5466-test-cs-split-on-6 branch March 26, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baileympearson baileympearson baileympearson approved these changes

Assignees

@baileympearson baileympearson

Labels
Primary Review In Review with primary reviewer, not yet ready for team's eyes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbbeeken @baileympearson