Conversation
mmeigs
reviewed
Aug 7, 2025
mmeigs
left a comment
mmeigs
left a comment
Collaborator
There was a problem hiding this comment.
Mainly just questions and cleanup!
| for idx in range(len(selection_ids)): | ||
| selection_id = selection_ids[idx] | ||
| try: | ||
| composable_option = self.composable_tutorial.composable_options[idx] |
Collaborator
There was a problem hiding this comment.
I bet this is right, but just checking that we shouldn't be using selection_id rather than idx here on line 2233?
Collaborator
There was a problem hiding this comment.
But this does leave another point. Could you add more commenting about the structure of this logic? You've named variables well but it's still pretty complicated for a first-time viewer.
mmeigs
approved these changes
Aug 8, 2025
mmeigs
left a comment
mmeigs
left a comment
Collaborator
There was a problem hiding this comment.
Thank you for the comment!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
DOP-5920
DOP-6050
Notes
PR skips id validation if a default id specified is "None" while having dependencies for that composable option - this means dependency can be unfulfilled and No Selection is allowed. See added test
Also removes the check for all children to be
.. selected-contentdirectives. This allows writers to have repeatable content under the select options in the UI. (front end PR will be linked here)NOTE: Above two requirements left me to move the handling of
.. selected-contentinto the post process, as we are allowing any other node within the structure, and this is where we handle nodes regardless of position, whereas parser expects certain positional nodes.NOTE: subsequent frontend PR is here (see staging links)
README updates