DOP-6049 adds new directives called multi-column and column#671
Conversation
seungpark
left a comment
There was a problem hiding this comment.
would like to see unit tests to see what the output in AST is
| options.title = "string" | ||
|
|
||
| [directive."multi-column"] | ||
| help = """A two-column component for the homepage""" |
There was a problem hiding this comment.
change to multi column component
There was a problem hiding this comment.
also, would add a note (or option) to note how each column would be presented in small vs big screen. the design shows each column being its own block
There was a problem hiding this comment.
@seungpark I can change the directive name to multi column component.
There was a problem hiding this comment.
i meant in the help line! im not sure if this is limited to two columns
There was a problem hiding this comment.
@seungpark gotcha, that makes sense. Right now, from the design, it is. I wanted to leave some flexibility for the writers in case they wanted to use it in another place.
Ticket
DOP-6049
Notes
Adds two new directives (multi-column, and column).
README updates