Skip to content

DOP-6049 adds new directives called multi-column and column#671

Merged
caesarbell merged 4 commits into
mainfrom
DOP-6049
Aug 11, 2025
Merged

DOP-6049 adds new directives called multi-column and column#671
caesarbell merged 4 commits into
mainfrom
DOP-6049

Conversation

@caesarbell

Copy link
Copy Markdown
Contributor

Ticket

DOP-6049

Notes

Adds two new directives (multi-column, and column).

README updates

    • This PR introduces changes that should be reflected in the README.md and/or HACKING.md, and I have made those updates.
    • This PR does not introduce changes that should be reflected in the README.md and/or HACKING.md

@seungpark seungpark left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would like to see unit tests to see what the output in AST is

Comment thread snooty/rstspec.toml Outdated
options.title = "string"

[directive."multi-column"]
help = """A two-column component for the homepage"""

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change to multi column component

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, would add a note (or option) to note how each column would be presented in small vs big screen. the design shows each column being its own block

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seungpark I can change the directive name to multi column component.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i meant in the help line! im not sure if this is limited to two columns

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seungpark gotcha, that makes sense. Right now, from the design, it is. I wanted to leave some flexibility for the writers in case they wanted to use it in another place.

@caesarbell
caesarbell merged commit 35898c5 into main Aug 11, 2025
6 checks passed
@caesarbell
caesarbell deleted the DOP-6049 branch August 11, 2025 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants