This repository was archived by the owner on Aug 12, 2022. It is now read-only.
Adds a note about Kiqstand and reusing connections. #247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kiqstand is responsible for both, to clean the IM and to disconnect. Maybe we should say both in the same paragraph instead. |
|
Kiqstand doesn't need to (and in my opinion, should not) disconnect anything. Sidekiq's workers are in fiber-local variables, they will disconnect automatically at the end of the job. |
|
See mongoid/kiqstand#10, and for a fuller explanation, see sidekiq/sidekiq#1526 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.