Skip to content

Conversation

IslandRhythms
Copy link
Contributor

I went a bit out of scope and also added an edit-boolean component. The current hurdle is getting undefined to propagate.

@IslandRhythms
Copy link
Contributor Author

So two things important to note:

  1. If the schema has the property default set to false, it will override the undefined value being passed
  2. if the collapsible is open when saving, it will be considered part of the changes

Copy link
Member

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of fixes/things to discuss but overall I like it.

One more feature I'd love to add: ability to switch to a JSON view similar to the one in models.html

image

@IslandRhythms
Copy link
Contributor Author

I've disabled editing when in JSON view. I hope that was the idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants