Skip to content

feat(custom-keymap): Custom Keymap Style (@thewickest) #6375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 44 commits into
base: master
Choose a base branch
from

Conversation

thewickest
Copy link

Description

Captura de pantalla 2025-03-14 a las 23 23 43
Pasted Graphic

New Keymap Style inside the Keymap section. This serves as a custom keymap where you can put the JSON content generated in the Keyboard Layout Editor or pages that generates equivalent content.
Features:

  1. If you include an object with an X in the array of keys, it will be treated as a blank key
  2. If you include an object with an W and a size, the size of the key will increment. Possible sizes right now are (1, 1.25, 1.5, 1.75, 2.25, 2.50, 6.25)
  3. If you want to maintain the dynamic features of the keymap style, you will have to fullfill the keymap with you prefered layout (qwerty, dvorak, etc).
  4. For adding and space, just write "spc" inside the key.

Checks

  • Adding quotes?
    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language or a theme?
    • If is a language, did you edit _list.json, _groups.json and add languages.json?
    • If is a theme, did you add the theme.css?
      • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.
  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)
  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

feature(custom-keymap): Custom Keymap Style(@thewickest)

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff packages Changes in local packages labels Mar 14, 2025
@thewickest thewickest changed the title Custom Keymap Style (@thewickest) feature(custom-keymap): Custom Keymap Style(@thewickest) Mar 14, 2025
@thewickest thewickest changed the title feature(custom-keymap): Custom Keymap Style(@thewickest) feat(custom-keymap): Custom Keymap Style(@thewickest) Mar 14, 2025
@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Mar 18, 2025
@fehmer
Copy link
Member

fehmer commented Mar 20, 2025

Hi, i did some testing.

  1. if you use the full size ansi example on kle
    [["Esc",{x:1},"F1","F2","F3","F4",{x:0.5},"F5","F6","F7","F8",{x:0.5},"F9","F10","F11","F12",{x:0.25},"PrtSc","Scroll Lock","Pause\nBreak"],[{y:0.5},"~\n`","!\n1","@\n2","#\n3","$\n4","%\n5","^\n6","&\n7","*\n8","(\n9",")\n0","_\n-","+\n=",{w:2},"Backspace",{x:0.25},"Insert","Home","PgUp",{x:0.25},"Num Lock","/","*","-"],[{w:1.5},"Tab","Q","W","E","R","T","Y","U","I","O","P","{\n[","}\n]",{w:1.5},"|\n\\",{x:0.25},"Delete","End","PgDn",{x:0.25},"7\nHome","8\n↑","9\nPgUp",{h:2},"+"],[{w:1.75},"Caps Lock","A","S","D","F","G","H","J","K","L",":\n;","\"\n'",{w:2.25},"Enter",{x:3.5},"4\n←","5","6\n→"],[{w:2.25},"Shift","Z","X","C","V","B","N","M","<\n,",">\n.","?\n/",{w:2.75},"Shift",{x:1.25},"↑",{x:1.25},"1\nEnd","2\n↓","3\nPgDn",{h:2},"Enter"],[{w:1.25},"Ctrl",{w:1.25},"Win",{w:1.25},"Alt",{w:6.25,a:7},"",{w:1.25,a:4},"Alt",{w:1.25},"Win",{w:1.25},"Menu",{w:1.25},"Ctrl",{x:0.25},"←","↓","→",{w:2,x:0.25},"0\nIns",".\nDel"]]
    the settings page is stuck loading with error message ERR Syntax error, unrecognized expression: .pageSettings .section[data-config-name='keymapCustom'] thrown in settings-groups:L130. The layout is not displaying correctly.

  2. Legends like "!\n1" don't work.

  3. Long legends overflow the key, e.g. [["CapsLock"]]

@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label Mar 25, 2025
@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Mar 27, 2025
@thewickest thewickest marked this pull request as ready for review April 12, 2025 21:14
@github-actions github-actions bot added the waiting for review Pull requests that require a review before continuing label Apr 12, 2025
Copy link
Contributor

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions github-actions bot added waiting for update Pull requests or issues that require changes/comments before continuing and removed waiting for review Pull requests that require a review before continuing labels Apr 17, 2025
@github-actions github-actions bot removed the waiting for update Pull requests or issues that require changes/comments before continuing label Apr 17, 2025
@Miodec
Copy link
Member

Miodec commented Apr 18, 2025

I tried a simple 60% and its not aligned

image

Also JD40

image

Ergodox is cursed

image

@Miodec Miodec added the waiting for update Pull requests or issues that require changes/comments before continuing label May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend User interface or web stuff packages Changes in local packages waiting for update Pull requests or issues that require changes/comments before continuing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants