Skip to content

fix(wordsInput): adjust #wordsInput position to be on the active word for chinese (@NadAlaba) #6545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025

Conversation

NadAlaba
Copy link
Contributor

@NadAlaba NadAlaba commented May 8, 2025

fix part of #6447

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label May 8, 2025
Copy link

sentry-io bot commented May 8, 2025

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: frontend/src/ts/test/test-ui.ts

Function Unhandled Issue
updateWordsInputPosition TypeError: Cannot read properties of null (reading 'style') ...
Event Count: 6 Affected Users: 121

Did you find this useful? React with a 👍 or 👎

Copy link
Member

@Miodec Miodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Miodec Miodec merged commit 3aaf2f6 into monkeytypegame:master May 12, 2025
14 checks passed
@NadAlaba NadAlaba deleted the fix-chinese-input-position branch May 13, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend User interface or web stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants