Skip to content

impr(settings): prevent customLayoutFluid and customPolyglot to be empty (@fehmer) #6548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 12, 2025

Conversation

fehmer
Copy link
Member

@fehmer fehmer commented May 10, 2025

Prevent user from deselecting all layouts/languages in customLayoutfluid and customPolyglot selects.

Fixes FRONTEND-MW and FRONTEND-MS

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label May 10, 2025
Copy link

sentry-io bot commented May 10, 2025

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: frontend/src/ts/pages/settings.ts

Function Unhandled Issue
fillSettingsPage Error: Failed to find a button element for fontFamily /set...
Event Count: 24 Affected Users: 79
fillSettingsPage TypeError: Cannot set properties of null (setting 'innerHTML') ...
Event Count: 10 Affected Users: 107

Did you find this useful? React with a 👍 or 👎

Copy link
Member

@Miodec Miodec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Miodec Miodec merged commit 48ed096 into master May 12, 2025
12 checks passed
@Miodec Miodec deleted the feature/add-minselect-to-settings branch May 12, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend User interface or web stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants