Skip to content

feat: add custom One Piece theme with animated text colors #6575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

drachmacollector
Copy link

Screenshot 2025-05-19 230834
Screenshot 2025-05-19 230925
Screenshot 2025-05-19 230836

Description

Checks

  • Adding quotes?

    • Make sure to include translations for the quotes in the description (or another comment) so we can verify their content.
  • Adding a language?

    • Make sure to follow the languages documentation
    • Add language to packages/contracts/src/schemas/languages.ts
    • Add language to exactly one group in frontend/src/ts/constants/languages.ts
    • Add language json file to frontend/static/languages
  • Adding a theme?

    • Make sure to follow the themes documentation
    • Add theme to packages/contracts/src/schemas/themes.ts
    • Add theme to frontend/src/ts/constants/themes.ts
    • Add theme css file to frontend/static/themes
  • Adding a layout?

    • Make sure to follow the layouts documentation
    • Add layout to packages/contracts/src/schemas/layouts.ts
    • Add layout json file to frontend/static/layouts
    • Also please add a screenshot of the theme, it would be extra awesome if you do so!
  • Check if any open issues are related to this PR; if so, be sure to tag them below.

  • Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info)

  • Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.

Closes #

added a theme that displays a One Piece themed look
added one_piece.css theme to the list
Copy link
Contributor

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and also include the author name at the end inside parenthesis. It looks like your proposed title needs to be adjusted.

Details:

Title "feat: add custom One Piece theme with animated text colors"
didn't match the configured pattern. Please ensure that the title
contains your name so that you can be credited in our changelog.

A correct version would look something like:

feat: add new feature (@github_username)
impr(quotes): add english quotes (@username)
fix(leaderboard): show user rank correctly (@user1, @user2, @user3)

@monkeytypegeorge monkeytypegeorge added frontend User interface or web stuff assets Languages, themes, layouts, etc. packages Changes in local packages labels May 19, 2025
Copy link
Contributor

Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes.

@github-actions github-actions bot added the waiting for update Pull requests or issues that require changes/comments before continuing label May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assets Languages, themes, layouts, etc. frontend User interface or web stuff packages Changes in local packages waiting for update Pull requests or issues that require changes/comments before continuing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants