Closed
Conversation
|
Triage Summary No labels will be applied due to a lack of specific context or content related to performance testing and other relevant areas. This issue is not a regression, as there are no specifics to suggest that previous functionalities are failing. Additional remarks:
Detailed Summary and ActionsSummary of the triage:
Summary of the actions that will be performed:
This entire triage process was automated by AI and mistakes may have been made. Please let us know so we can continue to improve. |
|
Were we able to find out what is causing this perf difference? If yes, is it fixable? |
mattleibow
added a commit
that referenced
this pull request
Feb 13, 2026
1 task
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR to investigate the crazy perf difference found here: https://github.com/wieslawsoltes/FastSkiaSharp
Discussion thread: https://x.com/wieslawsoltes/status/1984761177520685154
The native code is 120fps, but skiasharp is sub 10fps.
By first playing around found that I got to 40fps by using the new opengl flags in the SKGLView.
This all appears to be inside the skia code, which appears to be using similar compiler args.
My fork which downgrades skia to the same version in skiasharp is a tiny bit slower, 111-119 fps: https://github.com/mattleibow/FastSkiaSharp/tree/main_119
So the newer skia is faster, but only a bit. There is still a significant difference between teh code in the c++ and the C#