Disable serialization assembly generation#3542
Open
Conversation
Prevent Sgen from trying to load reference assemblies when used in projects that use legacy Xml serialization.
Contributor
|
Hey there @@mlsomers! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
Author
|
@dotnet-policy-service agree |
Contributor
|
/azp run |
|
No pipelines are associated with this pull request. |
Contributor
There was a problem hiding this comment.
Pull request overview
Disables MSBuild SGen serialization assembly generation for the core SkiaSharp library project to avoid build-time failures in legacy XmlSerializer workflows that can occur when reference assemblies are present.
Changes:
- Set
GenerateSerializationAssembliestoOffinbinding/SkiaSharp/SkiaSharp.csproj.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent Sgen from trying to load reference assemblies when used in projects that use legacy Xml serialization.
Description of Change
Added GenerateSerializationAssemblies tag with "off" to the main project
Bugs Fixed
A common issue with legacy projects using Xml serialization:
dotnet/msbuild#2707
Sgen generates code so that the runtime no longer needs to use reflection in order to serialize or deserialize xml, speeding up serialization considerably. Adding a reference to SkiaSharp breaks the feature.
API Changes
None.
Behavioral Changes
None.
Required skia PR
None.
PR Checklist
It has no runtime side effects, just prevents a compiletime error for some projects
No related PR found
Nothing needs to change