Merged
Conversation
- Replace Invoke-Expression with splatted args array ($runArgs) for proper exit code propagation — Invoke-Expression silently swallows non-zero exits - Continue through all projects to report ALL failures, then exit 1 - Use $LASTEXITCODE instead of $? for reliable native command error detection Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
utils/generate.ps1usesInvoke-Expression+$?to run the generator and check for errors. This silently swallows non-zero exit codes — if the generator crashes (e.g., CppAst parse failure on bad struct definitions), the script continues and exits 0.Fix
Invoke-Expressionwith splatted args array ($runArgs) and direct invocation via& dotnet @runArgs$runArgsarray used for both display (Write-Host) and execution (no duplication)Testing
Verified on macOS:
ERROR: Generation failed for libSkiaSharp.json with exit code 1