This repository was archived by the owner on Nov 3, 2023. It is now read-only.
Fix EnsureLocalDisposable rule (#18498) #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Mono.Cecil.Mdb 0.9.5 that is included in Mono 3.2
We need to keep track of local variables that reference other variables that hold disposable objects. The rule should not get triggered if we return one of these local variables. The Mono 3.2 compiler occasionally introduces such local variables.
Properties can return IDisposable objects, so we need to check those as well, otherwise we report false positives.
We shouldn't report an error if we temporarily store an object in a (new) variable and then return that. The Mono 3.2 compiler produces such code in debug mode.
We shouldn't report an error if we temporarily store an object in a (new) local variable and then return that. The Mono 3.2 compiler produces such code in debug mode.
Don't complain that dispose is not guaranteed if we return an object of that type. This catches the case where we dispose an object in a catch block that we otherwise return.
When a field gets assigned a disposable object created with initializers we shouldn't report this as failure.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.