-
Notifications
You must be signed in to change notification settings - Fork 60
DEPS: commented out obviously unneeded dependencies for Linux-only build, ~5GiB in total #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@dotnet-policy-service agree |
Why is the emsdk not needed when Skia is build for wasm? |
well, it would be needed in that case, but afaik you are never building it for wasm? |
it seems the git-sync-deps script supports specifying which OS a particular dependency is needed for, so maybe that could be used to avoid 5GiB of dependencies for wasm when following https://github.com/mono/SkiaSharp/wiki/Building-on-Linux, but I don't see how exactly one would do that |
use `cp build/linux-self-hosted/DEPS DEPS` to avoid downloading ~5GiB of dependencies which are not needed for a Linux build
in light of the dependencies being in fact necessary for the general build, I have reduced the scope to only affect the builds done according to https://github.com/mono/SkiaSharp/wiki/Building-on-Linux, which would happen by virtue of a copy command being added to the guide |
I have been commenting out various dependencies over time, so it is a bit less now. But, which dependencies did you remove? Maybe I can see if I can remove more generally. |
I don't recall exactly, it's just a matter of running |
I think half I already removed to avoid warnings, and this PR removes all the rest mono/SkiaSharp#3180 |
Thanks for the PR and starting the discussion. I think we should now be much smaller. I'll close this PR for now and if you see any further dependencies that we can skip, let me know! |
Description of Change
do not needlessly download ~5GiB of data that is not actually needed
API Changes
None.
Behavioral Changes
None.
PR Checklist
skiasharp
at time of PREDIT: it seems these dependencies are in fact needed for a general build.
the pull request now instead adds a new DEPS file in build/linux-self-hosted/DEPS.
if https://github.com/mono/SkiaSharp/wiki/Building-on-Linux is updated to add
cp build/linux-self-hosted/DEPS DEPS
beforepython tools/git-sync-deps
, this willsave downloading ~5GiB of unused dependencies