Update to new GrDirectContext::MakeMetal API#159
Merged
mattleibow merged 1 commit intomono:skiasharpfrom Aug 22, 2025
Merged
Conversation
5 tasks
mattleibow
requested changes
Aug 22, 2025
mattleibow
left a comment
There was a problem hiding this comment.
Thanks for this PR.
I think it is fine to just fix the code in src/gpu/ganesh/GrDirectContext.cpp
Then we don't need to worry later.
Author
Huh? But what I'm saying is that code is going to get removed upstream, then you'll get a conflict and you'll have to do this anyway... |
Also, use retain for setting the pointers to prevent GrMtlBackendContext from disposing the command queue.
eb833ed to
06fd747
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Update to new GrDirectContext::MakeMetal API for m124 and later.
Also, use retain for setting the pointers to prevent GrMtlBackendContext disposing the command queue.
SkiaSharp Issue
Fixes: mono/SkiaSharp#3178
API Changes
None.
Behavioral Changes
None.
Required SkiaSharp PR
Requires mono/SkiaSharp#3258
PR Checklist
skiasharpat time of PR