drop redundant SK_BUILD_FOR_WASM define#204
Open
ramezgerges wants to merge 1 commit into
Open
Conversation
include/private/base/SkFeatures.h auto-defines SK_BUILD_FOR_WASM under the __EMSCRIPTEN__ branch, so adding the same define on the em++ command line just produces a "macro redefined" warning on every wasm translation unit. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
include/private/base/SkFeatures.h auto-defines SK_BUILD_FOR_WASM under the EMSCRIPTEN branch, so adding the same define on the em++ command line just produces a "macro redefined" warning on every wasm translation unit.
Description of Change
SkiaSharp Issue
Related to https://github.com/mono/SkiaSharp/issues/
API Changes
None.
Behavioral Changes
None.
Required SkiaSharp PR
Requires https://github.com/mono/SkiaSharp/pull/
PR Checklist
skiasharpat time of PR