Skip to content

Conversation

@crydotsnake
Copy link
Contributor

No description provided.

@jacquesbh jacquesbh requested a review from Copilot November 4, 2025 10:05
@madamebiz madamebiz added the Status: needs review Needs review label Nov 4, 2025
Copy link
Member

@jacquesbh jacquesbh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds German translation files for a blog module, providing localized messages and validator strings for three German language variants: standard German (de), Austrian German (de_AT), and Swiss German (de_CH).

  • Adds comprehensive German translations for UI labels, form fields, validation messages, and menu items
  • Provides identical translations across all three German locales
  • Includes translations for blog articles, tags, authors, and case studies functionality

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/Resources/translations/messages.de.yaml Adds German translations for UI elements, forms, and menu providers
src/Resources/translations/messages.de_AT.yaml Adds Austrian German translations (identical to standard German)
src/Resources/translations/messages.de_CH.yaml Adds Swiss German translations (identical to standard German)
src/Resources/translations/validators.de.yaml Adds German validation message for duplicate slug constraint
src/Resources/translations/validators.de_AT.yaml Adds Austrian German validation message (identical to standard German)
src/Resources/translations/validators.de_CH.yaml Adds Swiss German validation message (identical to standard German)
Comments suppressed due to low confidence (2)

src/Resources/translations/messages.de_AT.yaml:1

  • Inconsistent indentation detected: this line uses 7 spaces while the parent 'provider' key at line 104 is indented correctly with 4 spaces. YAML requires consistent indentation for proper parsing. Change to 8 spaces (4 for 'provider' level + 4 for child keys).
    src/Resources/translations/messages.de.yaml:1
  • Inconsistent indentation detected: this line uses 7 spaces while the parent 'provider' key at line 104 is indented correctly with 4 spaces. YAML requires consistent indentation for proper parsing. Change to 8 spaces (4 for 'provider' level + 4 for child keys).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@crydotsnake
Copy link
Contributor Author

Copilot changes applied :)

@jacquesbh jacquesbh merged commit 4be775b into monsieurbiz:2.x Nov 4, 2025
8 checks passed
@jacquesbh
Copy link
Member

Thank you @crydotsnake!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants