-
Notifications
You must be signed in to change notification settings - Fork 10
Sylius 2.0 support 🎉 #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ce for const type
…are dispatch into dedicated services
…reconfirm feature
f871db6 to
687000c
Compare
| @@ -0,0 +1,62 @@ | |||
| {% extends '@SyliusShop/shared/components/confirmation_modal.html.twig' %} | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 suggestion:
| {% extends '@SyliusShop/shared/components/confirmation_modal.html.twig' %} | |
| {% extends '@SyliusAdmin/shared/components/confirmation_modal.html.twig' %} |
config/twig_hooks.yaml
Outdated
| @@ -0,0 +1,6 @@ | |||
| sylius_twig_hooks: | |||
| hooks: | |||
| # There is no other global hook to use in the admin size | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💣 chore:
| # There is no other global hook to use in the admin size | |
| # There is no other global hook to use in the admin side |
src/DependencyInjection/MonsieurBizSyliusMediaManagerExtension.php
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Filter on file selection
If the media manager aske me for an image, I can only select an image.
Now, I can select any type of file
image
Big file upload
image
Maybe we can check the behaviour on v1 or add a php ini in test file to allow big files to upload and make the Symfony validation works
Form fields labels
Can we have sample labels for fields ?
image
SVG not displayed
Maybe the same for ico ?
image
We can have an eye icon with link if we cannot display the image directly
Folder selection
We see the previous folder while the new is loading.
Can we empty the display when we close the modal ?
Enregistrement.de.l.ecran.2025-05-05.a.11.00.17.mov
src/Factory/FileFactory.php
Outdated
| public function createParentLinkFile(string $absoluteDirectoryPath): FileInterface | ||
| { | ||
| $file = new File(); | ||
| $file->setName('...'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| $file->setName('...'); | |
| $file->setName('..'); |



Demo
Select a file
add_image.mov
Select a file but with type error
not_of_type.mov
Remove a file
remove_image.mov
Upload file
upload_from_type.mov
Upload file with error
upload_with_bad_type.mov
Delete file with confirm
delete_file_with_confirm.mov
Add subfolder
add_subfolder.mov
Tests
For tests [TYPE] will be:
Know potential bugs or problems
Sometime when switching between modal, the black transparent background of Boostrap modal not removed