Skip to content

Conversation

@maximehuran
Copy link
Member

@maximehuran maximehuran commented Aug 13, 2025

Dispatch event for another live components !

@madamebiz madamebiz added the quick win Easy to pick, everybody will be happy. label Aug 13, 2025
@maximehuran maximehuran requested a review from Copilot August 13, 2025 10:34
@madamebiz madamebiz added the Status: needs review Needs review label Aug 13, 2025

This comment was marked as outdated.

@maximehuran maximehuran requested a review from Copilot August 13, 2025 10:38
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds event dispatching functionality to the FormField component to enable communication with other live components when a file is selected. The change emits a media-manager:file-selected event containing the input name and file path data.

  • Adds event emission on file selection in the FormField component
  • Includes Copilot instructions documentation for development guidelines

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/Components/FormField.php Adds event dispatching when a file path is set
.github/copilot-instructions.md Adds development guidelines and coding standards

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@maximehuran maximehuran merged commit d86c62a into monsieurbiz:2.x Aug 13, 2025
8 checks passed
@maximehuran maximehuran deleted the feature/event branch August 13, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

quick win Easy to pick, everybody will be happy. Status: needs review Needs review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants