Skip to content

Conversation

@petitbx
Copy link

@petitbx petitbx commented Jan 18, 2025

Sylius 2.0 Checklist

  • Image element works (add image, update image) - Media manager compatibility can be added later
  • Live Collections form works - Try with image collection element and text collection element
  • Button labels on collection form Add and Delete can be customized
  • Markdown UI Element works, shown in front with highlighted content
  • Copy / Paste one element works
  • Delete one element works
  • Copy / Paste all elements works
  • Delete all elements works
  • Confirmation modal works
  • Columns and Row layout elements works with multiple level (Example, lines in columns etc.)
  • Icons are displayed
  • Dist files are up to date (Especially the display product description in front template)
  • Custom Google Maps element works
  • Custom Text collection element works, wysiwyg element are loaded with Live Collections
  • The No See element is not shown
  • The rich content is displayed in product description in shop
  • Refactor LiveCollection to make it work without override
  • Update recipe in Mbiz repo
  • Put the description in a tooltip like in v1 now
  • Tooltip on Copy / Paste / Delete buttons
  • Add autocomplete debug element and make it work
  • Form errors are displayed when element not valid
  • Live collection Image, if you edit the element, and you add or remove an element, the images are lost.
  • Live collection text, if you add multiple elements, onlythe last content is kept. The other are sent empty.
  • Improve form collection display (no empty grey frame, delete button and form in a container, flex display...)
  • Mechanism to transfer the locale in children editors works
  • Check all the TODOs in code
  • README compatibilities updated
  • README link to branch for Sylius 1.x compatibility
  • UPGRADE small guide
  • Be sure locale is passed correctly to all forms
  • Test UI Element display front
  • Test UI Element display admin
  • Admin templates of all elements are up to date
  • Shop templates of all elements are up to date
  • HTML UI Element as html tag twice in card display
  • Fix CI
  • On edit product autocomplete, the autocomplete display is cropped
  • Improve fixtures to have each UI elements in product descriptions
  • Issue when you add new image in image collection which is to huge Unable to dehydrate value of type "array" for property "data" on component "MonsieurBiz\SyliusRichEditorPlugin\Twig\Components\UiElementForm
  • Correct TODO about fakepath

closes #252

@maximehuran
Copy link
Member

I made some test and you made an amazing job !

I see an issue that I was working on on my side, the form collections.
For example if you choose an Image collection element, the form is not loaded :

image

Form collections seems to be managed with Live component now, and not in JQuery like before.

@maximehuran
Copy link
Member

Another issue with Image element, the selected image is not displayed

image

Also in the form

image

@petitbx
Copy link
Author

petitbx commented Jan 19, 2025

Yes, I saw these problems.
I also have 2 others problems, first one is markdown to html, the filter doesn't work and the other one is, I inject jQuery manually with a script balise...
But I'm still working on this upgrade !

@maximehuran
Copy link
Member

We will work on these issues soon. We will update your pull request ☺️

Thank you for your work !

@petitbx petitbx marked this pull request as draft January 20, 2025 10:59
@maximehuran maximehuran force-pushed the feat/sylius-2.0 branch 7 times, most recently from f490f28 to 74dfb9e Compare March 21, 2025 13:46
@maximehuran maximehuran marked this pull request as ready for review May 12, 2025 16:13
@madamebiz madamebiz added the Status: needs review Status: needs review label May 12, 2025
@lanfisis lanfisis changed the title WIP: update for sylius 2.0 Sylius 2.0 support 🎉 May 13, 2025
@madamebiz madamebiz added Status: needs update This Issue/PR needs update and removed Status: needs review Status: needs review labels May 13, 2025
@maximehuran maximehuran requested a review from lanfisis May 13, 2025 08:14
@madamebiz madamebiz added Status: needs review Status: needs review and removed Status: needs update This Issue/PR needs update labels May 13, 2025
@madamebiz madamebiz added Status: needs update This Issue/PR needs update and removed Status: needs review Status: needs review labels May 14, 2025
@maximehuran maximehuran requested a review from delyriand May 14, 2025 12:21
@madamebiz madamebiz added Status: needs review Status: needs review and removed Status: needs update This Issue/PR needs update labels May 14, 2025
@maximehuran maximehuran changed the base branch from master to 2.x May 14, 2025 12:38
@maximehuran maximehuran merged commit c394ac7 into monsieurbiz:2.x May 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: needs review Status: needs review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2.0 Compatibility

5 participants