Skip to content

Empty forms to avoid duplicate ids when multiple editors #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2025
Merged

Empty forms to avoid duplicate ids when multiple editors #258

merged 1 commit into from
Feb 5, 2025

Conversation

@maximehuran
Copy link
Member

@maximehuran maximehuran commented Jan 31, 2025 •
edited
Loading

Empty forms to be sure we don't have duplicates IDs when we have multiples editors in the same element :

image

The Ui Element is not in the plugin directly

@madamebiz madamebiz added the quick win Easy to pick, everybody will be happy. label Jan 31, 2025
@madamebiz madamebiz added the Status: needs review Status: needs review label Jan 31, 2025
@jacquesbh
Copy link
Member

jacquesbh commented Jan 31, 2025

Is there really no risk about having glitches in UI?
Or even are we really sure this fix works for all nested forms? Like having a rich editor in a rich editor in a rich editor… Since in that case we could have many forms…

What is the main issue that you have? Cannot we fix the related issue by using another trick?

@maximehuran
Copy link
Member Author

maximehuran commented Jan 31, 2025

Is there really no risk about having glitches in UI? Or even are we really sure this fix works for all nested forms? Like having a rich editor in a rich editor in a rich editor… Since in that case we could have many forms…

What is the main issue that you have? Cannot we fix the related issue by using another trick?

I have tested that cases

@maximehuran maximehuran merged commit 663bc49 into monsieurbiz:master Feb 5, 2025
15 checks passed
@maximehuran maximehuran deleted the feature/multiple-editors branch February 5, 2025 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@delyriand delyriand delyriand approved these changes

@lanfisis lanfisis lanfisis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

quick win Easy to pick, everybody will be happy. Status: needs review Status: needs review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@maximehuran @jacquesbh @delyriand @lanfisis @madamebiz