Fix #201 - authorize empty search #202
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximehuran
reviewed
Sep 23, 2024
Member
maximehuran
left a comment
maximehuran
left a comment
There was a problem hiding this comment.
Why do you want to allow empty search ?
delyriand
suggested changes
Sep 23, 2024
delyriand
left a comment
delyriand
left a comment
There was a problem hiding this comment.
🎯 suggestion: See my comment in the issue #201 (comment), i suggest to throw a NotFoundException in the postAction
delyriand
approved these changes
Sep 24, 2024
maximehuran
reviewed
Oct 1, 2024
Member
maximehuran
left a comment
maximehuran
left a comment
There was a problem hiding this comment.
Why do you want to allow empty search ?
What is the goal of that ?
Contributor
Author
just to avoid an error see #201 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #201