Skip to content

fix(populate): Better TypeError handling on AutoMapper::map before indexing #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2024
Merged

fix(populate): Better TypeError handling on AutoMapper::map before indexing #224

merged 1 commit into from
Oct 21, 2024

Conversation

@welcoMattic
Copy link
Contributor

@welcoMattic welcoMattic commented Oct 21, 2024 •
edited
Loading

In case of TypeError exception is thrown by Automapper::map call, the indexation will not be stopped. Instead the command will display this king of error message

Error while mapping App\Entity\Taxonomy\Taxon (id: 1): 
MonsieurBiz\SyliusSearchPlugin\Generated\Model\TaxonDTO::setName(): 
Argument #1 ($name) must be of type string, null given [...]

@welcoMattic welcoMattic force-pushed the fix/automapper-type-error-handling branch from 2e80b81 to 6d0c77f Compare October 21, 2024 09:44
@maximehuran maximehuran merged commit 3423cda into master Oct 21, 2024
12 checks passed
@maximehuran maximehuran deleted the fix/automapper-type-error-handling branch October 21, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maximehuran maximehuran maximehuran approved these changes

@lanfisis lanfisis Awaiting requested review from lanfisis

@Kiwikoti Kiwikoti Awaiting requested review from Kiwikoti

+1 more reviewer

@delyriand delyriand delyriand approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Status: needs review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@welcoMattic @delyriand @maximehuran @madamebiz