Skip to content

Features/commonjs #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cdebost wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Features/commonjs #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8ad7784
Change deprecated tmpDir to tmpdir
cdebost May 16, 2018
418d385
Fix issue that replaces filenames with objects
cdebost May 16, 2018
aed27a0
Add package-lock.json
cdebost May 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/template-base.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ exports.TemplateBase = Object.create(Object.prototype, {
if (typeof this.didSetOptions === "function") {
this.didSetOptions(options);
}
var mainBuildDir = Path.join(os.tmpDir(), "build");
var mainBuildDir = Path.join(os.tmpdir(), "build");
this.buildDir = Path.join(mainBuildDir, this.options.templateName);
var self = this;
return qfs.exists(mainBuildDir).then(function(exists) {
Expand Down Expand Up @@ -243,7 +243,7 @@ exports.TemplateBase = Object.create(Object.prototype, {
var newName = filename,
options = this.options;
for (var name in options) {
if (options.hasOwnProperty(name)) {
if (options.hasOwnProperty(name) && typeof options[name] === "string") {
newName = newName.replace(
FILENAME_VARIABLE_START + name + FILENAME_VARIABLE_END,
options[name]
Expand Down
Loading