Simplify sample template #96
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The straightforward bit:
.editorconfig,.gitignore,LICENSE.md,README.mdfiles. Not necessary in a sample.For review:
assets/style/style.cssfrom samples in favor of using the main app's stylesheet. I think it's much better to ensure some consistency in the global style rules and avoid surprises when moving from the sample to the actual app.assets/iconsdirectory, usingfavicon.icoas the icon instead. Also removes said icons from the manifest file and removes some responsive web app tags fromindex.html. Based on my understanding, we'd only need these icons to make samples into progressive web apps, which I don't think there would ever be a reason for.