Extract TopologySpreadSkews to named type to fix controller-gen panic#53
Open
moabukar wants to merge 1 commit intomonzo:masterfrom
Open
Extract TopologySpreadSkews to named type to fix controller-gen panic#53moabukar wants to merge 1 commit intomonzo:masterfrom
moabukar wants to merge 1 commit intomonzo:masterfrom
Conversation
The inline anonymous struct for TopologySpreadSkews in ExternalServiceSpec causes controller-gen to crash with a nil pointer dereference when running `make manifests`. Extracting it to a named type resolves the panic. This also regenerates the CRD manifest, which was out of date and missing the topologySpreadSkews and serviceTrafficDistribution fields added in monzo#47 and monzo#48. Fixes monzo#49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make manifestscurrently panics with a nil pointer dereference in controller-gen due to theTopologySpreadSkewsfield being declared as an inline anonymous struct insideExternalServiceSpec.This extracts it to a named
TopologySpreadSkewstype, which resolves the panic and allowsmake manifeststo complete successfully.The CRD manifest has also been regenerated - it was out of date and missing the
topologySpreadSkewsandserviceTrafficDistributionfields added in #47 and #48.Fixes #49