Fix boolean pointer marshalling #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olib963
commented
Mar 13, 2025
|
|
||
| if tc.platErr.IsRetryable == nil { | ||
| assert.False(t, protoError.Retryable.Value) | ||
| assert.Nil(t, protoError.Retryable) |
Contributor
Author
There was a problem hiding this comment.
This is the behaviour change.
olib963
commented
Mar 13, 2025
|
|
||
| if tc.platErr.IsUnexpected == nil { | ||
| assert.False(t, protoError.Unexpected.Value) | ||
| assert.Nil(t, protoError.Unexpected) |
tompreston
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #54, we're currently marshalling boolean pointers incorrectly. If you
Marshalaterrors.ErrorthenUnmarshalit again you will get&falseif the input was eithernilor&falseleading to a loss in data.We might consider this a breaking change due to Hyrum's Law. While the
Unexpected()andRetryable()functions will have the same output, the underlying fields will now benilwhere they were not before.