Skip to content

Use DialTLSContext instead of DialTLS when negotiating HTTP2 session #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joechrisellis merged 2 commits into from
Feb 24, 2023
Merged

Use DialTLSContext instead of DialTLS when negotiating HTTP2 session #161

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a9d85c0
Use DialTLSContext instead of DialTLS when negotiating HTTP2 session
joechrisellis Feb 23, 2023
dd1c028
Merge branch 'master' into http2-negotiation-respect-context-deadline
suhailpatel Feb 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,9 @@ var (
AllowHTTP: true,
// This monstrosity is needed to get the http2 Transport to dial over cleartext.
// See https://github.com/thrawn01/h2c-golang-example
DialTLS: func(network, addr string, _ *tls.Config) (net.Conn, error) {
return net.Dial(network, addr)
DialTLSContext: func(ctx context.Context, network, addr string, _ *tls.Config) (net.Conn, error) {
var d net.Dialer
return d.DialContext(ctx, network, addr)
},
}
)
Expand Down